Skip to content

Backporting Tuned rendering and MCP detection improvements#971

Closed
rbaturov wants to merge 1 commit intoopenshift:release-4.14from
rbaturov:4.14-renedring
Closed

Backporting Tuned rendering and MCP detection improvements#971
rbaturov wants to merge 1 commit intoopenshift:release-4.14from
rbaturov:4.14-renedring

Conversation

@rbaturov
Copy link
Contributor

@rbaturov rbaturov commented Feb 28, 2024

render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles.

added default MCP creation to help correctly render out the resources for performance profile to use

upkeep: fix spelling

  • feat: add default mcpools to tuned renderer

  • Enhance render sync to include bootstrap rendering tests

  • Render MC without additional PP

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

  • Render sync

@MarSik @jlojosnegros
@eggfoobar @rbaturov
OCPBUGS-27948: Tuned rendering and MCP detection improvements (opensh…
5ee029e 
…ift#928)

* NTO: Add MCP name to filter PP (openshift#878)

render-bootcmd-mc can only compute the kernel args for a
MachineConfigPool that matches the node it is executed on, so we add the
MachineConfigPool name as input parameter to filter the applicable
PerformanceProfiles.

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>

* OCPBUGS-22095: Add default MCP objects for rendering (openshift#833)

* feat: update render command to create default MCPs

added default MCP creation to help correctly render out the resources for performance profile to use

Signed-off-by: ehila <ehila@redhat.com>

upkeep: fix spelling

Signed-off-by: ehila <ehila@redhat.com>

* feat: add default mcpools to tuned renderer

Signed-off-by: ehila <ehila@redhat.com>

---------

Signed-off-by: ehila <ehila@redhat.com>

* Enhance render sync to include bootstrap rendering tests

* Render MC without additional PP

This command should render a MC from the available sources.
PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no
additional PP let's the command proceed even if there is no PP

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>

* Render sync

---------

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Co-authored-by: Jose Luis Ojosnegros <jojosneg@redhat.com>
Co-authored-by: E Hila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2024

@rbaturov: This pull request references Jira Issue OCPBUGS-27948, which is invalid:

  • expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15.0" instead
  • expected dependent Jira Issue OCPBUGS-22095 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-22095 to target a version in 4.15.0, 4.15.z, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles.

added default MCP creation to help correctly render out the resources for performance profile to use

upkeep: fix spelling

  • feat: add default mcpools to tuned renderer

  • Enhance render sync to include bootstrap rendering tests

  • Render MC without additional PP

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

  • Render sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rbaturov rbaturov changed the title OCPBUGS-27948: Tuned rendering and MCP detection improvements (#928) OCPBUGS-27948: Tuned rendering and MCP detection improvements Feb 28, 2024
@rbaturov rbaturov changed the title OCPBUGS-27948: Tuned rendering and MCP detection improvements Tuned rendering and MCP detection improvements Feb 28, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2024

@rbaturov: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles.

added default MCP creation to help correctly render out the resources for performance profile to use

upkeep: fix spelling

  • feat: add default mcpools to tuned renderer

  • Enhance render sync to include bootstrap rendering tests

  • Render MC without additional PP

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

  • Render sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rbaturov rbaturov changed the title Tuned rendering and MCP detection improvements Backporting Tuned rendering and MCP detection improvements Feb 28, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign jmencak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanirq
Copy link
Contributor

yanirq commented Mar 4, 2024

@rbaturov please add bug title once https://issues.redhat.com/browse/OCPBUGS-27948 is cloned for 4.14

@yanirq
Copy link
Contributor

yanirq commented Mar 4, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

@rbaturov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 5ee029e link true /test e2e-aws-ovn
ci/prow/e2e-no-cluster 5ee029e link true /test e2e-no-cluster
ci/prow/e2e-gcp-pao 5ee029e link true /test e2e-gcp-pao
ci/prow/images 5ee029e link true /test images
ci/prow/unit 5ee029e link true /test unit
ci/prow/e2e-hypershift 5ee029e link true /test e2e-hypershift
ci/prow/e2e-gcp-pao-updating-profile 5ee029e link true /test e2e-gcp-pao-updating-profile
ci/prow/e2e-upgrade 5ee029e link true /test e2e-upgrade
ci/prow/e2e-gcp-pao-workloadhints 5ee029e link true /test e2e-gcp-pao-workloadhints
ci/prow/vet 5ee029e link true /test vet
ci/prow/e2e-aws-operator 5ee029e link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rbaturov
Copy link
Contributor Author

rbaturov commented Mar 7, 2024

/hold
Further backports need to be done like
901f395
to continue.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Mar 15, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Mar 16, 2024

@rbaturov is this PR still needed ?

@rbaturov
Copy link
Contributor Author

rbaturov commented Mar 17, 2024

@rbaturov is this PR still needed ?

Yes, it's required to backport #954.

@yanirq
Copy link
Contributor

yanirq commented Mar 17, 2024

@rbaturov is this PR still needed ?

Yes, it's required to backport #954.

Did you mean #928 ? (954 is not directly related)

@rbaturov
Copy link
Contributor Author

rbaturov commented Mar 17, 2024

@rbaturov is this PR still needed ?

Yes, it's required to backport #954.

Did you mean #928 ? (954 is not directly related)

I meant that it will be needed to backport #954 in the future, which is indirectly related (but depends on this).

@rbaturov rbaturov closed this Apr 9, 2024
@rbaturov rbaturov deleted the 4.14-renedring branch April 9, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlojosnegros jlojosnegros Awaiting requested review from jlojosnegros

@kpouget kpouget Awaiting requested review from kpouget

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rbaturov @openshift-ci-robot @yanirq @openshift-merge-robot @MarSik